|
Thanks to Martin Fowler's Refactoring book, there's been a lot of documentation on what "bad" code smells are, and how to fix them--but what about "good" code smells?
What constitutes a "good" code smell? Is there any code that you've run into during ...
Started by plaureano on
, 10 posts
by 10 people.
Answer Snippets (Read the full thread at stackoverflow):
When thingsWhenever I've looked at a good open-source .NET project, I've always been surprised how few lines it, but know it when I see....
So code that is free from repetition (DRY) smells great.
The biggest code smell is repetition.
|
|
Scott W. Ambler has put up a good list of basic database smell s. It would be good to see how these can be corrected, what database refactorings can be applied as a remedy and if any smells are missing from the list.
For ground rules when replying, take...
Started by Danijel Arsenovski on
, 5 posts
by 5 people.
Answer Snippets (Read the full thread at stackoverflow):
I tend to find that a proliferation of "flags" is a smell that initial "flag smell....
With null values for most rows Lack of check constraints Lack of Normalization (in 80% case this is good rules in stored procs, to me, is a smell.
|
|
It occurs to me (as I'm reviewing some old code) that there may be a standard way of rating code smells and I'm just not familiar with it.
To be clear: I'm familiar with a few taxonomies of code smells , what I'm looking for is a standard rating system...
Started by Dan Esparza on
, 5 posts
by 5 people.
Answer Snippets (Read the full thread at stackoverflow):
A good book about detecting and rating code smells is Object-Oriented Metrics in Practice: Using Software Metrics to Characterize, Evaluate for detecting code smells....
And/or both of these cases then it's much 'smellier' than if not .
|
Ask your Facebook Friends
|
Possible Duplicate:
What are some bad programming habits to look out for and avoid?
This is not a Code Smells question, but a Coding Smell Question aka programmer's working habits. What are known coding smells and steps to correct them. Example:
Coding...
Started by meade on
, 4 posts
by 4 people.
Answer Snippets (Read the full thread at stackoverflow):
A code file has 10-20-30+ thousands of lines, contains smell: looking the specs through, thinking you know what they want, starting to implement them for code smell, but instead bad programming....
What you mentioned are not code smells.
|
|
I finally used one of my 20% off coupons from BBB and bought a Farberware percolator to replace my dead Mr. Coffee drip maker. Part of it was a memory thing from my childhood and the aroma of the coffee brewing in the house first thing in the morning....
Started by hugsandkisses on
, 24 posts
by 24 people.
Answer Snippets (Read the full thread at qvc):
My dad stilll uses his and takes it with him the smell of it !
"Sometimes good things fall apart so that Better Things can fall together" using a Corning Ware stovetop....
Nothing smells or tastes as good.
Beats the Superfast.
|
|
4laugh
Started by dirthouse on
, 15 posts
by 6 people.
Answer Snippets (Read the full thread at gaiaonline):
4laugh Sadakai I like when you can still smell the shampoo....
Heart someone finally took a shower exclaim I smell Ota Aoki someone finally took a shower exclaim precisely 4laugh I like when you can still smell the shampoo in your hair.
|
|
I am 31 yrs old and I've been playing poker for 4-5 years now. HU has been my main game since 2008. I currently play up to 10/20 NL.
As a coach, I've had the opportunity to help ~55 different students over the last 3 years and have been endorsed by Cardrunners...
Started by Stake Monster on
, 15 posts
by 8 people.
Answer Snippets (Read the full thread at twoplustwo):
Post graph of smellyness please! Just to confirm that I indeed smell terrific, here are some a video and which he reviewed (and I defiantly....
Always.
Plus he's a great coach.
Can talk on there? I can confirm Stake Monster does smell good.
|
|
Its kinda freaking me out.
Started by mujarimojo on
, 14 posts
by 5 people.
Answer Snippets (Read the full thread at sf-central):
Its all good.
I tried to get as much sleep at possible, so I skipped taking a 2nd shower .
But then his left armpit will smell good and the right one will smell mediocre in comparison! The cycle called out.
|
|
We're generally familiar with code smells here, but just as damaging if not more so are when the business side of things - as much as it falls within our domain - is going wrong.
As examples, the inverse of anything on the Joel test would be considered...
Started by annakata on
, 10 posts
by 10 people.
Answer Snippets (Read the full thread at stackoverflow):
They aren't always....
Real shame-related smells.
Good new people are laid of because they tried to change the process.
- " we'll productize it later " Some smells I have seen:
Optimistic management, but they can't pay it all goes down.
|
|
I wrote this yesterday, in a class Foo inheriting from Bar:
public override void AddItem(double a, int b) { //Code smell? throw new NotImplementedException("This method not usable for Foo items"); }
Wondered subsequently if this is a possible indication...
Started by Benjol on
, 9 posts
by 9 people.
Answer Snippets (Read the full thread at stackoverflow):
The AddItem method Animal { void Breathe() const=0; } class Dog... .
The example you gave above is clearly a code smell.
Only could, though, smells aren't always correct.
To the Bar that it owns, this could indicate that it should be a Bar .
|
